Skip to content

fix(frontend): allow resolution of v6 addresses. (backport release-3.4.x) #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Jun 27, 2025

Backport 8481b34 from #18251


What this PR does / why we need it:

Query-frontend resolves its own address and passes that information to scheduler & queriers, it gets used to send back the query response to the corresponding frontend. Current frontends only resolve v4 addresses, trying to using V2 frontend (frontend + scheduler combination) breaks for users running loki on v6 only interfaces.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@loki-gh-app loki-gh-app bot added backport size/S type/bug Somehing is not working as expected labels Jun 27, 2025
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner June 27, 2025 14:20
@loki-gh-app loki-gh-app bot requested a review from ashwanthgoli June 27, 2025 14:20
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loki-gh-app loki-gh-app bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 27, 2025
@ashwanthgoli ashwanthgoli enabled auto-merge (squash) June 27, 2025 14:23
@ashwanthgoli ashwanthgoli merged commit 93e0880 into release-3.4.x Jun 27, 2025
70 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-18251-to-release-3.4.x branch June 27, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
1 participant