Skip to content

fix(frontend): allow resolution of v6 addresses. #18251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025
Merged

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Jun 27, 2025

What this PR does / why we need it:

Query-frontend resolves its own address and passes that information to scheduler & queriers, it gets used to send back the query response to the corresponding frontend. Current frontends only resolve v4 addresses, trying to using V2 frontend (frontend + scheduler combination) breaks for users running loki on v6 only interfaces.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner June 27, 2025 10:31
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to run make docs to update the configuration reference.

Base automatically changed from fix-memberlist-v6 to main June 27, 2025 13:03
@ashwanthgoli ashwanthgoli enabled auto-merge (squash) June 27, 2025 13:08
Copy link
Contributor

github-actions bot commented Jun 27, 2025

💻 Deploy preview deleted.

@ashwanthgoli ashwanthgoli merged commit 8481b34 into main Jun 27, 2025
67 checks passed
@ashwanthgoli ashwanthgoli deleted the frontend-resolve-v6 branch June 27, 2025 13:15
loki-gh-app bot pushed a commit that referenced this pull request Jun 27, 2025
loki-gh-app bot pushed a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants