Skip to content

feat(helm): add missing revisionHistoryLimit - #18638

Merged
Jayclifford345 merged 8 commits into
grafana:mainfrom
DrFaust92:missing-revisionHistoryLimit
Aug 5, 2025
Merged

feat(helm): add missing revisionHistoryLimit#18638
Jayclifford345 merged 8 commits into
grafana:mainfrom
DrFaust92:missing-revisionHistoryLimit

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Aligns passing revisionHistoryLimit to some missed resources

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
DrFaust92 marked this pull request as ready for review July 29, 2025 11:59
@DrFaust92
DrFaust92 requested a review from a team as a code owner July 29, 2025 11:59
@DrFaust92
DrFaust92 marked this pull request as draft July 30, 2025 19:27
Comment thread production/helm/loki/CHANGELOG.md Outdated
Comment thread production/helm/loki/templates/loki-canary/daemonset.yaml Outdated
DrFaust92 and others added 4 commits July 31, 2025 13:24
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
DrFaust92 marked this pull request as ready for review July 31, 2025 17:28

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one Changelog is
Messy

Comment thread production/helm/loki/CHANGELOG.md Outdated
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
@Jayclifford345
Jayclifford345 merged commit d0e0d1a into grafana:main Aug 5, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants