Skip to content

feat(helm): add missing revisionHistoryLimit #18638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jayclifford345 merged 8 commits into from
Aug 5, 2025
Merged

feat(helm): add missing revisionHistoryLimit #18638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e47d0f1
add missing revisionHistoryLimit
DrFaust92 Jul 29, 2025
dbd8b33
changelog
DrFaust92 Jul 29, 2025
52124d9
Update production/helm/loki/templates/loki-canary/daemonset.yaml
DrFaust92 Jul 31, 2025
18366b7
Merge branch 'main' into missing-revisionHistoryLimit
DrFaust92 Jul 31, 2025
982def6
changelog
DrFaust92 Jul 29, 2025
988a992
changelog
DrFaust92 Jul 31, 2025
d60c1fe
changelog
DrFaust92 Jul 31, 2025
4b25dd3
Merge branch 'main' into missing-revisionHistoryLimit
Jayclifford345 Aug 5, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Entries should include a reference to the pull request that introduced the chang

[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)

- [BUGFIX] make loki.storage.bucketNames are optional, if builtin minio is enabled.
- [ENHANCEMENT] add missing revisionHistoryLimit to `admin-api`, `enterprise-gateway`, and `loki-canary`. [#18638](https://github.com/grafana/loki/pull/18638)
- [FEATURE] Expose all storage configuration properties [#18509](https://github.com/grafana/loki/pull/18509)
- [CHANGE] Add `tpl()` support for `pattern_ingester`, `ingester_client` and `compactor_grpc_client` components. [#16759](https://github.com/grafana/loki/pull/16759)
- [CHANGE] Common Config : Use grpc for contacting the compactor in distributed deployment, rather than http. The compactor_grpc_address parameter replaces the compactor_address in the default commonConfig section of values.yaml. If the compactor_address parameter is set, the compactor_grpc_address must be set to an empty string. Careful, the loki.compactorAddress helper now returns the address of the compactor in grpc format rather than http. [#17454](https://github.com/grafana/loki/pull/17454)
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/admin-api/deployment-admin-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
{{- include "enterprise-logs.adminApiSelectorLabels" . | nindent 6 }}
strategy:
{{- toYaml .Values.adminApi.strategy | nindent 4 }}
revisionHistoryLimit: {{ .Values.loki.revisionHistoryLimit }}
template:
metadata:
labels:
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/gateway/deployment-gateway-enterprise.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
{{- include "loki.gatewaySelectorLabels" . | nindent 6 }}
strategy:
{{- toYaml .Values.enterpriseGateway.strategy | nindent 4 }}
revisionHistoryLimit: {{ .Values.loki.revisionHistoryLimit }}
template:
metadata:
labels:
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/loki-canary/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ spec:
type: RollingUpdate
rollingUpdate:
maxUnavailable: 1
revisionHistoryLimit: {{ $.Values.loki.revisionHistoryLimit }}
{{- else }}
{{- with .updateStrategy }}
updateStrategy:
Expand Down
Loading