Skip to content

feat(helm): add namespaceOverride - #18707

Merged
Jayclifford345 merged 14 commits into
grafana:mainfrom
jkroepke:helm/namespaceOverride
Aug 27, 2025
Merged

feat(helm): add namespaceOverride#18707
Jayclifford345 merged 14 commits into
grafana:mainfrom
jkroepke:helm/namespaceOverride

Conversation

@jkroepke

@jkroepke jkroepke commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Allow overriding namespace for Loki helm chart resources.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jkroepke
jkroepke requested a review from a team as a code owner August 3, 2025 19:37
@jkroepke

jkroepke commented Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

@QuentinBisson QuentinBisson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but that was not a fun review 😂

@QuentinBisson

Copy link
Copy Markdown
Contributor

@jkroepke can you fix the conflicts?

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke

jkroepke commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

Done

Comment thread production/helm/loki/templates/_helpers.tpl Outdated
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Comment thread production/helm/loki/templates/_helpers.tpl Outdated
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@jkroepke
jkroepke requested a review from QuentinBisson August 18, 2025 16:49
jkroepke and others added 3 commits August 18, 2025 18:50
# Conflicts:
#	production/helm/loki/templates/provisioner/job-provisioner.yaml
#	production/helm/loki/templates/tokengen/clusterrolebinding-tokengen.yaml
#	production/helm/loki/templates/tokengen/job-tokengen.yaml
#	production/helm/loki/templates/tokengen/serviceaccount-tokengen.yaml
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
@Jayclifford345

Copy link
Copy Markdown
Contributor

Hi team, I am currently getting a helm CI issue for this PR:

Installing chart with values file "production/helm/loki/ci/non-default-values.yaml"...

Creating namespace "loki-u8zjw0ktrj"...
namespace/loki-u8zjw0ktrj created
Error: INSTALLATION FAILED: namespaces "loki" not found
========================================================================================================================
........................................................................................................................
==> Events of namespace loki-u8zjw0ktrj
........................................................................................................................
No resources found in loki-u8zjw0ktrj namespace.
........................................................................................................................
<== Events of namespace loki-u8zjw0ktrj
........................................................................................................................
========================================================================================================================
Deleting release "loki-u8zjw0ktrj"...
release "loki-u8zjw0ktrj" uninstalled
Deleting namespace "loki-u8zjw0ktrj"...
namespace "loki-u8zjw0ktrj" deleted
Namespace "loki-u8zjw0ktrj" terminated.
Error: failed installing charts: failed processing charts

------------------------------------------------------------------------------------------------------------------------
 ✖︎ loki => (version: "6.36.1", path: "production/helm/loki") > failed waiting for process: exit status 1
------------------------------------------------------------------------------------------------------------------------
failed installing charts: failed processing charts
Error: Process completed with exit code 1.
Comment thread production/helm/loki/ci/non-default-values.yaml Outdated
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@jkroepke

Copy link
Copy Markdown
Contributor Author

@Jayclifford345 please trigger the CI again

JStickler and others added 3 commits August 22, 2025 16:50
Signed-off-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345
Jayclifford345 merged commit 5ca4dca into grafana:main Aug 27, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants