Skip to content

feat(loki-helm): allow override namespace for loki helm chart #11989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasoares
Copy link

@lucasoares lucasoares commented Feb 19, 2024

What this PR does / why we need it:

Allow overriding namespace for Loki helm chart resources.

Which issue(s) this PR fixes:
Fixes #8044

Special notes for your reviewer:

Waiting for feedback before updating changelogs/docs and chart version

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@lucasoares lucasoares requested a review from a team as a code owner February 19, 2024 18:08
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@bonddim
Copy link

bonddim commented Jun 23, 2025

Link issue from helm-charts grafana/helm-charts#3577

@grafana/loki-team

@Jayclifford345
Copy link
Contributor

Hi @lucasoares, thank you for this, if you wouldn't fixing the conflicts I think this would be a nice edition to the helm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment