feat(loki-mixin): allow disabling thanos dashboard and fix dashboard's file name - #18749
Conversation
|
Hey @fcjack ! Sorry for tagging you, I saw you had reviewed a few PRs and the original one that had added this dashboard and I was hoping to get your thoughts on this change. Thanks for your time and contribution ! 🙏 |
fcjack
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution
Great thanks for the review @fcjack ! I see that some workflows are waiting for aproval, as this is my first time contributing in this specific repository is there anything on my end that needs to be done ? |
@WhiteDiamondz I see that you've signed the CLA, so you're good to go. I'll merge this as soon as the checks pass. |
What this PR does / why we need it:
This PR allows disabling the thanos dashboard if not used and fixes it's unconventional json name.
Which issue(s) this PR fixes:
Trying to apply the generated dashboard's file would give the following error:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR