Skip to content

feat(loki-mixin): allow disabling thanos dashboard and fix dashboard's file name #18749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JStickler merged 4 commits into from
Sep 5, 2025
Merged

feat(loki-mixin): allow disabling thanos dashboard and fix dashboard's file name #18749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d6723
feat(loki-mixin): allow hiding thanos dashboard if not used and fix d…
WhiteDiamondz Aug 7, 2025
064e4ae
Merge branch 'main' into main
WhiteDiamondz Sep 3, 2025
f0ad06f
Merge branch 'main' into main
WhiteDiamondz Sep 5, 2025
71a9011
Merge branch 'main' into main
JStickler Sep 5, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...ashboards/loki_thanos_object_storage.json → ...ashboards/loki-thanos-object-storage.json
View file
Open in desktop
File renamed without changes.
0 ...ashboards/loki_thanos_object_storage.json → ...ashboards/loki-thanos-object-storage.json
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions production/loki-mixin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ To test the dashboards against a local grafana & Loki setup perform the followin
### Pre-requisites

* jb is a jsonnet package manager
To install it follow the instructions at: https://github.com/jsonnet-bundler/jsonnet-bundler.
To install it follow the instructions at: <https://github.com/jsonnet-bundler/jsonnet-bundler>.

* Grizzly is a tool for managing jsonnet dashboards in Grafana: https://github.com/grafana/grizzly.
To install it follow the instructions at: https://grafana.github.io/grizzly/installation/.
* Grizzly is a tool for managing jsonnet dashboards in Grafana: <https://github.com/grafana/grizzly>.
To install it follow the instructions at: <https://grafana.github.io/grizzly/installation/>.

* Make sure you have the latest dependencies in the `vendor` directory by running the following command in `production/loki-mixin`:

```shell
jb install
```

* On your Grafana instance create an API key with role 'Admin' under Configuration > API keys.
* On your Grafana instance create an API key with role 'Admin' under Configuration > API keys.
Copy this key for the next step.

### Testing dashboards
Expand Down
5 changes: 5 additions & 0 deletions production/loki-mixin/config.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
enabled: true,
},

thanos: {
// Whether or not to include thanos specific dashboards
enabled: true,
},

operational: {
// Whether or not to include memcached in the operational dashboard
memcached: true,
Expand Down
4 changes: 2 additions & 2 deletions production/loki-mixin/dashboards/loki-object-store.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ local grafana = import 'grafonnet/grafana.libsonnet';
local row = grafana.row;

{
grafanaDashboards+:: {
grafanaDashboards+:: if !$._config.thanos.enabled then {} else {
local cluster_namespace_matcher = 'cluster="$cluster", namespace=~"$namespace"',
local dashboard = (
(import 'dashboard-utils.libsonnet') + {
_config+:: $._config,
}
),
'loki_thanos_object_storage.json':
'loki-thanos-object-storage.json':
dashboard.dashboard('Loki / Object Store Thanos', uid='object-store')
.addCluster()
.addNamespace()
Expand Down
Loading