Skip to content

fix(helm): Roll back change to Thanos ruler storage - #18907

Merged
Jayclifford345 merged 3 commits into
mainfrom
hotfix-thanos-ruler
Aug 21, 2025
Merged

fix(helm): Roll back change to Thanos ruler storage#18907
Jayclifford345 merged 3 commits into
mainfrom
hotfix-thanos-ruler

Conversation

@Jayclifford345

@Jayclifford345 Jayclifford345 commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Roll back the change made to introduce Thanos-compatible storage for the ruler. needs further work and testing to introduce without breaking current implementations

Partially reverts 18740

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@Jayclifford345
Jayclifford345 requested a review from a team as a code owner August 19, 2025 09:37
@github-actions

Copy link
Copy Markdown
Contributor

Helm Diff Output - Summary

Default Values Scenario-diff-output
Distributed Scenario-diff-output
Ingress Values Scenario-diff-output
Legacy Monitoring Values Scenario-diff-output
Simple Scalable AWS Kube IRSA Values Scenario-diff-output
Simple Thanos Values Scenario-diff-output
580c580,590
<           bucketnames: ruler
---
>           access_key_id: thanos-minio
>           bucket_name: ruler_thanos
>           endpoint: http://minio.minio.svc.cluster.local:9000
>           http:
>             tls_config:
>               insecure_skip_verify: true
>           insecure: true
>           region: us-east-1
>           secret_access_key: thanos-minio123
>           sse: {}
>         storage_prefix: null
1239c1249
<         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
>         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1345c1355
<         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
>         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1449c1459
<         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
>         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1665c1675
<         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
>         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
2081c2091
<         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
>         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
Single Binary Scenario-diff-output

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Revert as suggested in the comment #18784 (comment)

According docs, it might be works, but not sure why not.

@JStickler JStickler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dug around to find the PR this is reverting (#18740). LGTM

@Jayclifford345
Jayclifford345 merged commit 43dfc97 into main Aug 21, 2025
79 checks passed
@Jayclifford345
Jayclifford345 deleted the hotfix-thanos-ruler branch August 21, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants