fix(helm): Roll back change to Thanos ruler storage - #18907
Merged
Conversation
Contributor
Helm Diff Output - SummaryDefault Values Scenario-diff-outputDistributed Scenario-diff-outputIngress Values Scenario-diff-outputLegacy Monitoring Values Scenario-diff-outputSimple Scalable AWS Kube IRSA Values Scenario-diff-outputSimple Thanos Values Scenario-diff-output580c580,590
< bucketnames: ruler
---
> access_key_id: thanos-minio
> bucket_name: ruler_thanos
> endpoint: http://minio.minio.svc.cluster.local:9000
> http:
> tls_config:
> insecure_skip_verify: true
> insecure: true
> region: us-east-1
> secret_access_key: thanos-minio123
> sse: {}
> storage_prefix: null
1239c1249
< checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
> checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1345c1355
< checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
> checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1449c1459
< checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
> checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
1665c1675
< checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
> checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
2081c2091
< checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
---
> checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209Single Binary Scenario-diff-output |
jkroepke
reviewed
Aug 20, 2025
Contributor
There was a problem hiding this comment.
LGTM.
Revert as suggested in the comment #18784 (comment)
According docs, it might be works, but not sure why not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Roll back the change made to introduce Thanos-compatible storage for the ruler. needs further work and testing to introduce without breaking current implementations
Partially reverts 18740
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR