fix(helm): Do not strip whitespace in target definitions for querier and read deployments - #19464
Merged
Merged
Conversation
…and read deployments
Merged
6 tasks
Contributor
Author
|
We should not strip whitespaces on the list of args, otherwise they will be in one line and the arg parser of loki gets wrong arguments,
https://github.com/grafana/loki/actions/runs/18384060163/job/52379407344#step:10:2271 |
trevorwhitney
approved these changes
Oct 9, 2025
trevorwhitney
left a comment
Collaborator
There was a problem hiding this comment.
thank you for following up with the CI fix, looks like the last one got merged inadvertently.
Contributor
Author
|
It seems like the Helm CI is not part of the required Checks, maybe this is confusing. |
Collaborator
|
@jkroepke I don't know how to make a conditional check required, so no, the helm checks aren't required |
…and read deployments
Contributor
Author
|
gateway was broken as well: |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow-up of #19461 (Helm CI was red, was not good to merged)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR