Skip to content

fix(helm): Update querier, read, and single binary target definitions for UI enablement - #19461

Merged
JStickler merged 1 commit into
grafana:mainfrom
jkroepke:helm/ui
Oct 9, 2025
Merged

fix(helm): Update querier, read, and single binary target definitions for UI enablement#19461
JStickler merged 1 commit into
grafana:mainfrom
jkroepke:helm/ui

Conversation

@jkroepke

@jkroepke jkroepke commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Fixes an regression introduced in #19390

Currently, the Loki helm chart fails to start with the following error:

unrecognised module name: %sall
level=info ts=2025-10-09T08:43:39.575741888Z caller=main.go:126 msg="Starting Loki" version="(version=3.5.5, branch=release-3.5.x, revision=5aa8bd27)"
level=info ts=2025-10-09T08:43:39.575768698Z caller=main.go:127 msg="Loading configuration file" filename=/etc/loki/config/config.yaml
level=error ts=2025-10-09T08:43:39.575788074Z caller=log.go:223 msg="error running loki" err="unrecognised module name: %sall"

and blocking all Helm related PRs

/cc @rfratto @trevorwhitney

Which issue(s) this PR fixes:

Special notes for your reviewer:

I skip the CHANGELOG notice, since this is fixing a bug which was not released yet.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jkroepke
jkroepke requested a review from a team as a code owner October 9, 2025 17:30

@trevorwhitney trevorwhitney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I missed this, thanks!

@JStickler
JStickler merged commit 087430e into grafana:main Oct 9, 2025
77 of 80 checks passed
@jkroepke
jkroepke deleted the helm/ui branch October 9, 2025 18:48
@jkroepke

jkroepke commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Hey @trevorwhitney the CI was still red for Helm, because of other errors related to UI. So I created a follow-up #19464

I had no chance to review the CI before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants