Skip to content

fix: reduce FetchMaxBytes to 10MB - #19883

Merged
grobinson-grafana merged 1 commit into
mainfrom
grobinson/reduce-fetch-max-bytes
Nov 17, 2025
Merged

fix: reduce FetchMaxBytes to 10MB#19883
grobinson-grafana merged 1 commit into
mainfrom
grobinson/reduce-fetch-max-bytes

Conversation

@grobinson-grafana

@grobinson-grafana grobinson-grafana commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This pull request reduces FetchMaxBytes from 100MB to 10MB. This was causing OOMs when connected to multiple brokers with equal_spread, and also putting a lot of pressure on the GC to keep within GOMEMLIMIT of 512MB. Decreasing it to 10MB seems to have no negative effect on throughput having tested it in one of our dev cells.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana
grobinson-grafana requested a review from a team as a code owner November 16, 2025 23:46
@grobinson-grafana
grobinson-grafana merged commit 82cfafd into main Nov 17, 2025
67 checks passed
@grobinson-grafana
grobinson-grafana deleted the grobinson/reduce-fetch-max-bytes branch November 17, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants