Skip to content

fix: reduce FetchMaxBytes to 10MB #19883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grobinson-grafana merged 1 commit into from
Nov 17, 2025
Merged

fix: reduce FetchMaxBytes to 10MB #19883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/limits/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ func New(cfg Config, limits Limits, logger log.Logger, reg prometheus.Registerer
kgo.OnPartitionsRevoked(s.partitionLifecycler.Revoke),
kgo.OnPartitionsLost(s.partitionLifecycler.Lost),
// For now these are hardcoded, but we might choose to make them
// configurable in the future. We allow up to 100MB to be buffered
// in total, and up to 1.5MB per partition. If an instance consumes
// configurable in the future. We allow up to 10MB to be buffered
// per broker, and up to 1.5MB per partition. If an instance consumes
// all partitions, then it can buffer 1.5MB * 64 partitions = 96MB.
// This allows us to run with less than 512MB of allocated heap using
// a GOMEMLIMIT of 512MiB.
kgo.FetchMaxBytes(100_000_000), // 100MB
kgo.FetchMaxBytes(10_000_000), // 10MB
kgo.FetchMaxPartitionBytes(1_500_000), // 1.5MB
)
if err != nil {
Expand Down