Ruler: Disable x-scope-orgid header append in remote write - #11819
Merged
dannykopping merged 9 commits intoFeb 14, 2024
Conversation
jburnham
force-pushed
the
jburnham/ruler-disable-x-scope-orgid
branch
2 times, most recently
from
January 29, 2024 22:01
a6bad93 to
89e4ac2
Compare
jburnham
force-pushed
the
jburnham/ruler-disable-x-scope-orgid
branch
from
January 29, 2024 22:10
89e4ac2 to
91f91b1
Compare
jburnham
marked this pull request as ready for review
January 29, 2024 22:32
Contributor
Author
|
Had an open ticket with AWS about this behavior and received the following reply.
They then also linked to this PR. |
dannykopping
approved these changes
Feb 13, 2024
dannykopping
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with a minor nit.
Co-authored-by: Danny Kopping <dannykopping@gmail.com>
Contributor
Author
|
@dannykopping I ran |
Contributor
|
Thanks for your contribution @jburnham 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds option to disable addition of X-Scope-OrgID header in ruler remote write config. Needed to remote write to Amazon Managed Prometheus (Cortex).
Which issue(s) this PR fixes:
I suspect (but cannot prove) this will add a workaround for this existing open issue #9438
Special notes for your reviewer:
This is a similar PR from the Tempo project where it could not remote write to Amazon Managed Prometheus. We were having the same issues with the X-Scope-OrgID header that now works once this header is disabled.
Related issue from Tempo project
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR