fix: add extraEnvFrom to the global variables in the helm chart

[simonfelding]

What this PR does / why we need it:
Makes the helm values.yaml work like the documentation in values.yaml says it does.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[simonfelding]

This is in reference to this line:

loki/production/helm/loki/values.yaml

Line 114 in c9c0e9a

# Such environment variables can be then stored in a separate Secret and injected via the global.extraEnvFrom value. For details about environment injection from a Secret please see [Secrets](https://kubernetes.io/docs/concepts/configuration/secret/#use-case-as-container-environment-variables).

[simonfelding]

Also solves #11391

[MichelHollands]

@simonfelding Thanks for this contribution. The documentation hasn't been updated as mentioned in the failing CI step. Can you fix this? Once that is done I'll merge this.

[simonfelding]

@MichelHollands Thanks for the quick response. I've tried running make -C docs sources/setup/install/helm/reference.md as the CI step says, but it doesn't change anything so there is nothing to commit. Any clues on what to do?

[simonfelding]

@MichelHollands ping :)

[MichelHollands]

@MichelHollands ping :)

Can you remove that file and rerun the make step? Also please update the version everywhere.

[ormandj]

@simonfelding this one is impacting us as well, thank you for the PR, is there anything we can do to help move this along?

[simonfelding]

@simonfelding this one is impacting us as well, thank you for the PR, is there anything we can do to help move this along?

Oops, forgot about it and changed jobs. I'm on vacation right now, but how about you make a pull request to my repo that fixes it?

[sdwilsh]

@simonfelding, I rebased and updated your work in your repo in simonfelding#1

[simonfelding]

Thank you so much @sdwilsh - you need to sign the CLA ! This is important. You have to press the recheck button after you do it.

@MichelHollands @JStickler we are ready to merge now!

[JStickler]

@simonfelding Closing as duplicate of #16062

[simonfelding]

@JStickler that's rude. We worked on this for free and you just copy it and close our PR when it's finished. Why can't we get credit for our work? This is not very encouraging for future community contributions.

[JStickler]

@simonfelding, my apologies, it was not my intent to be rude or dismissive of your contribution. It happened that I had just reviewed the updates to the docs in the other PR, then reviewed this PR and realized that you were adding the same global variable. So I closed this PR adding a single variable in favor of the other PR adding five variables. I want you to know that we've had quite a few Slack threads discussing how best to respond to your comments, and to acknowledge your work, as we do care about our community members.