feat(helm): Add support for STS Endpoint and init containers for query-frontend, query-scheduler and distributor - #13519
Closed
tiagoposse wants to merge 1 commit into
Closed
feat(helm): Add support for STS Endpoint and init containers for query-frontend, query-scheduler and distributor#13519tiagoposse wants to merge 1 commit into
tiagoposse wants to merge 1 commit into
Conversation
|
Tiago Posse seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
tiagoposse
changed the title
…query-scheduler and distributor
github-actions
Bot
added
the
type/docs
jkroepke
reviewed
Jul 17, 2025
jkroepke
left a comment
jkroepke
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for your PR, please take note of my comments and sigh the CLA.
| securityContext: | ||
| {{- toYaml .Values.loki.podSecurityContext | nindent 8 }} | ||
| terminationGracePeriodSeconds: {{ .Values.queryScheduler.terminationGracePeriodSeconds }} | ||
| {{- with .Values.queryScheduler.initContainers }} |
Contributor
There was a problem hiding this comment.
please add this to values.yaml
| securityContext: | ||
| {{- toYaml .Values.loki.podSecurityContext | nindent 8 }} | ||
| terminationGracePeriodSeconds: {{ .Values.queryFrontend.terminationGracePeriodSeconds }} | ||
| {{- with .Values.queryFrontend.initContainers }} |
Contributor
There was a problem hiding this comment.
please add this to values.yaml
| securityContext: | ||
| {{- toYaml .Values.loki.podSecurityContext | nindent 8 }} | ||
| terminationGracePeriodSeconds: {{ .Values.distributor.terminationGracePeriodSeconds }} | ||
| {{- with .Values.distributor.initContainers }} |
Contributor
There was a problem hiding this comment.
please add this to values.yaml
| s3: | ||
| s3: null | ||
| endpoint: null | ||
| sts_endpoint: null |
Contributor
There was a problem hiding this comment.
Suggested change
| sts_endpoint: null | |
| stsEndpoint: null |
| # loki | ||
|
|
||
|    | ||
|    |
| type: application | ||
| appVersion: 3.0.0 | ||
| version: 6.6.6 | ||
| version: 6.7.0 |
Comment on lines
+16
to
+17
| ## 6.7.0 | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| ## 6.7.0 |
| "secretAccessKey": null, | ||
| "signatureVersion": null | ||
| "signatureVersion": null, | ||
| "sts_endpoint": null |
Contributor
There was a problem hiding this comment.
Suggested change
| "sts_endpoint": null | |
| "stsEndpoint": null |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the sts_endpoint config introduced in #13518, and support for extra init containers for query-frontend, query-scheduler and distributor. This is helpful for several use cases. In my case this allows using self-signed certificates for the STS endpoint.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR