feat(helm): Support s3 storage class - #13718
Closed
devsunb wants to merge 2 commits into
Closed
Conversation
|
|
github-actions
Bot
added
area/helm
type/docs
devsunb
force-pushed
the
main
branch
2 times, most recently
from
August 4, 2024 10:26
5076a54 to
bfdf36e
Compare
jkroepke
reviewed
Jul 15, 2025
jkroepke
left a comment
jkroepke
left a comment
Contributor
There was a problem hiding this comment.
Check, the configuration is part of the docs: https://grafana.com/docs/loki/latest/configure/#s3_storage_config
Could you please rebase the PR and take note of my comments?
|
|
||
| ## 6.10.3 | ||
|
|
||
| - [FEATURE] Add support S3 storage class |
Contributor
There was a problem hiding this comment.
Suggested change
| - [FEATURE] Add support S3 storage class | |
| - [FEATURE] Add support S3 storage class [#13718](https://github.com/grafana/loki/pull/13718) |
|
|
||
| [//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.) | ||
|
|
||
| ## 6.10.3 |
Contributor
There was a problem hiding this comment.
please remove the version bump, not longer nessesary
| type: application | ||
| appVersion: 3.1.1 | ||
| version: 6.10.2 | ||
| version: 6.10.3 |
Contributor
There was a problem hiding this comment.
please remove the version bump, not longer nessesary
| # loki | ||
|
|
||
|    | ||
|    |
Contributor
There was a problem hiding this comment.
please remove the version bump, not longer nessesary
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support S3 storage class option in helm chart
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR