Skip to content

fix: Unescape JSON strucutred metadata string values - #13919

Merged
owen-d merged 1 commit into
grafana:mainfrom
hvenev:fix-json
Apr 8, 2025
Merged

fix: Unescape JSON strucutred metadata string values#13919
owen-d merged 1 commit into
grafana:mainfrom
hvenev:fix-json

Conversation

@hvenev

@hvenev hvenev commented Aug 18, 2024

Copy link
Copy Markdown
Contributor

In the case of strings, ObjectEach strips the quotes but does not unescape them.

What this PR does / why we need it:
Fixes #13918

Which issue(s) this PR fixes:
Fixes #13918

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
In the case of strings, `ObjectEach` strips the quotes but does not
unescape them.

Fixes grafana#13918
@hvenev
hvenev requested a review from a team as a code owner August 18, 2024 13:38
@CLAassistant

CLAassistant commented Aug 18, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@0x006EA1E5

Copy link
Copy Markdown

Hi @hvenev I am having a similar problem to you.

Is your fix available as a docker build anywhere, to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants