Skip to content

fix: logcli: Check for errors before checking for exists when fetching data #14780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: logcli: Check for errors before checking for exists when fetching data #14780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
First check for errors
  • Loading branch information
@DylanGuedes
DylanGuedes committed Nov 5, 2024
commit d00b9d80f7ee32211253da991b47917dbfe9a5bc
6 changes: 3 additions & 3 deletions pkg/logcli/query/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,12 +553,12 @@ func LoadSchemaUsingObjectClient(oc chunk.ObjectClient, name string) (*config.Sc
defer cancel()

ok, err := oc.ObjectExists(ctx, name)
if !ok {
return nil, errNotExists
}
if err != nil {
return nil, err
}
if !ok {
return nil, errNotExists
}

rdr, _, err := oc.GetObject(ctx, name)
if err != nil {
Expand Down
Loading