Skip to content

revert: "perf(bloom): Compute chunkrefs for series right before sending task to builder" #14839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

revert: "perf(bloom): Compute chunkrefs for series right before sending task to builder" #14839

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6029a0
Revert "perf(bloom): Compute chunkrefs for series right before sendin…
salvacorts Nov 8, 2024
5a26e7e
fix for revert
salvacorts Nov 8, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix for revert
  • Loading branch information
@salvacorts
salvacorts committed Nov 8, 2024
commit 5a26e7ed524be4bf2c07cc48ea7888af06953cbc
2 changes: 1 addition & 1 deletion pkg/bloombuild/common/tsdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func NewTSDBSeriesIter(ctx context.Context, user string, f sharding.ForSeries, b
user,
bounds,
0, math.MaxInt64,
func(_ labels.Labels, fp model.Fingerprint, _ []index.ChunkMeta) (stop bool) {
func(_ labels.Labels, fp model.Fingerprint, chks []index.ChunkMeta) (stop bool) {
select {
case <-ctx.Done():
return true
Expand Down
Loading