Skip to content

feat(blooms): disk-backed queue for the bloom-planner #14874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat(blooms): disk-backed queue for the bloom-planner #14874

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015e123
feat(blooms): disk-backed queue for the bloom-planner
salvacorts Nov 12, 2024
d733889
CR
salvacorts Nov 12, 2024
51d4c57
Update pkg/bloombuild/planner/queue/queue.go
salvacorts Nov 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update pkg/bloombuild/planner/queue/queue.go 
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
  • Loading branch information
@salvacorts @chaudum
salvacorts and chaudum authored Nov 13, 2024
commit 51d4c57e7240d336c1f3ce7436824cca9c3b6300
2 changes: 1 addition & 1 deletion pkg/bloombuild/planner/queue/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func NewQueue(
}

func (q *Queue) starting(ctx context.Context) error {
// TODO(salvacorts): We can recover the queue from the disk here.
// TODO(salvacorts): We do not recover the queue from the disk yet.
// Until then, we just remove all the files in the directory so the disk
// doesn't grow indefinitely.
if q.cfg.StoreTasksOnDisk && q.cfg.CleanTasksDirectory {
Expand Down
Loading