Skip to content

feat(blooms): Prefetch bloom blocks as soon as they are built #15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 22, 2024
Merged

feat(blooms): Prefetch bloom blocks as soon as they are built #15050

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fd25955
feat(blooms): Add PrefetchBloomBlocks to bloomgateway service
salvacorts Nov 21, 2024
204acaa
Implement `PrefetchBloomBlocks` gRPC method on gateway
chaudum Nov 21, 2024
a90607d
fixup! Implement `PrefetchBloomBlocks` gRPC method on gateway
chaudum Nov 21, 2024
b141863
fixup! fixup! Implement `PrefetchBloomBlocks` gRPC method on gateway
chaudum Nov 21, 2024
94face5
Builders call PrefetchBloomBlocks
salvacorts Nov 21, 2024
6a79cee
fixup
salvacorts Nov 21, 2024
685e871
CR feedback
salvacorts Nov 21, 2024
bb2c7c2
remove unused cfg
salvacorts Nov 21, 2024
d3fc8be
use running ctx to fetch blocks async
salvacorts Nov 21, 2024
db765bb
pass background ctx
salvacorts Nov 21, 2024
7fc112c
increase queue size
salvacorts Nov 21, 2024
1679110
Skip reporting hit/miss in cache
salvacorts Nov 21, 2024
a1ae1b0
Metrics
salvacorts Nov 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@salvacorts
salvacorts committed Nov 21, 2024
commit 6a79cee9c6f90af8449fbf77a5121e0102e8e0d7
2 changes: 1 addition & 1 deletion pkg/bloombuild/builder/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func setupBuilder(t *testing.T, plannerAddr string, limits Limits, logger log.Lo
metrics := storage.NewClientMetrics()
metrics.Unregister()

builder, err := New(cfg, limits, schemaCfg, storageCfg, metrics, nil, fakeBloomStore{}, logger, prometheus.NewPedanticRegistry(), nil)
builder, err := New(cfg, limits, schemaCfg, storageCfg, metrics, nil, fakeBloomStore{}, nil, logger, prometheus.NewPedanticRegistry(), nil)
require.NoError(t, err)

return builder
Expand Down
Loading