Skip to content

fix: incorrect error check in autoCommitLoop #15149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: incorrect error check in autoCommitLoop #15149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: incorrect error check in autoCommitLoop
  • Loading branch information
@grobinson-grafana
grobinson-grafana committed Nov 27, 2024
commit 65e0b6fc5f462ac863306e32884402fb4ea2c5e6
10 changes: 6 additions & 4 deletions pkg/kafka/partition/committer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ func (c *partitionCommitter) autoCommitLoop(ctx context.Context) {
continue
}

if err := c.Commit(ctx, currOffset); err == nil {
level.Error(c.logger).Log("msg", "failed to commit", "offset", currOffset)
c.lastCommittedOffset.Set(float64(currOffset))
previousOffset = currOffset
if err := c.Commit(ctx, currOffset); err != nil {
level.Error(c.logger).Log("msg", "failed to commit", "offset", currOffset, "err", err)
continue
}

c.lastCommittedOffset.Set(float64(currOffset))
previousOffset = currOffset
}
}
}
Expand Down