Skip to content

feat: update blockbuilder to use scheduler for fetching jobs #15224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 4, 2024
Merged

feat: update blockbuilder to use scheduler for fetching jobs #15224

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8b2f67c
chore: split kafka reader into reader and offset manager
ashwanthgoli Dec 3, 2024
0f8bf25
lint
ashwanthgoli Dec 3, 2024
bfa2a41
metric rename
ashwanthgoli Dec 3, 2024
85ed8c7
feat: integrate block builder to use the scheduler interface
ashwanthgoli Dec 3, 2024
9950524
wire transport
ashwanthgoli Dec 3, 2024
705b277
tidy
ashwanthgoli Dec 3, 2024
6002f04
make doc
ashwanthgoli Dec 3, 2024
283e4e1
make format
ashwanthgoli Dec 3, 2024
9b0d0b4
Merge branch 'main' into blockbuilder-use-scheduler
ashwanthgoli Dec 4, 2024
4addff2
remove files
ashwanthgoli Dec 4, 2024
786186a
register metrics once
ashwanthgoli Dec 4, 2024
8ae9af3
Merge branch 'main' into blockbuilder-use-scheduler
ashwanthgoli Dec 4, 2024
c5cba68
fixup! Merge branch 'main' into blockbuilder-use-scheduler
ashwanthgoli Dec 4, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! Merge branch 'main' into blockbuilder-use-scheduler
  • Loading branch information
@ashwanthgoli
ashwanthgoli committed Dec 4, 2024
commit c5cba680835906d8723542ed7b48a78ddc697727
2 changes: 1 addition & 1 deletion pkg/loki/modules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,8 +1820,8 @@ func (t *Loki) initBlockBuilder() (services.Service, error) {
return nil, err
}

readerMetrics := partition.NewReaderMetrics(prometheus.DefaultRegisterer)
readerFactory := func(partitionID int32) (partition.Reader, error) {
readerMetrics := partition.NewReaderMetrics(prometheus.DefaultRegisterer)
return partition.NewKafkaReader(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will panic b/c it's creating new clients each time, each which use the same metrics namespacing internally. Instead, we could create a single client which creates cheap copies via a WithPartition(x) -> Self or similar.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is safe to make copies of kgo.Client. we'd need separate instances of it as we mutate it while setting offset for consumption.

working around this by registering metrics only once 786186a.
t.Cfg.KafkaConfig,
partitionID,
Expand Down
Loading