Skip to content

fix(aggregated_metrics): Fix the IsError method causing retries #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix(aggregated_metrics): Fix the IsError method causing retries #15296

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993806b
Fix the IsError method causing retries
shantanualsi Dec 6, 2024
ae46b7b
Change isError logic
shantanualsi Dec 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change isError logic 
Co-authored-by: Ned Andreev <n@andreev.sh>
  • Loading branch information
@shantanualsi @na--
shantanualsi and na-- authored Dec 6, 2024
commit ae46b7b1c343799d5f19492631cc718812d36392
2 changes: 1 addition & 1 deletion pkg/util/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ func ErrorTypeFromHTTPStatus(status int) string {
}

func IsError(status int) bool {
return status/100 != 2
return status < 200 || status >= 300
}

func IsServerError(status int) bool {
Expand Down
Loading