Skip to content

Conversation

@loki-gh-app
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 6, 2024

Backport 7a7b3b1 from #15296


What this PR does / why we need it:
The IsError method does not return true even though status is 204. This is causing retries that makes aggregated metrics incorrect.
This PR fixes it and adds some tests.

#incident-2024-12-05-metric-aggregation-is-broken

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Co-authored-by: Ned Andreev <n@andreev.sh>
(cherry picked from commit 7a7b3b1)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner December 6, 2024 13:24
@loki-gh-app loki-gh-app bot added the type/bug Somehing is not working as expected label Dec 6, 2024
@loki-gh-app loki-gh-app bot requested a review from shantanualsi December 6, 2024 13:24
@na-- na-- merged commit b02997b into k231 Dec 6, 2024
64 checks passed
@na-- na-- deleted the backport-15296-to-k231 branch December 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/M type/bug Somehing is not working as expected

2 participants