Skip to content

perf: Improve approx_topk performance by reducing allocations. #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 19, 2024
Merged

perf: Improve approx_topk performance by reducing allocations. #15450

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
714aa0a
Benchmark HeapCountMinSketchVectorAdd
jeschkies Dec 17, 2024
e19a384
Remove the smallest element when max is reached.
jeschkies Dec 17, 2024
dc5dacd
Add todo
jeschkies Dec 17, 2024
fb1f72e
Check metrics capacity
jeschkies Dec 17, 2024
dd8fe62
Check length and capacity
jeschkies Dec 17, 2024
f15dcae
Do net realloc
jeschkies Dec 17, 2024
19cfc52
Convert labels to bytes slice with a buffer to avoid allocations.
jeschkies Dec 18, 2024
0024eaa
Remove todo
jeschkies Dec 18, 2024
c220803
Fix test
jeschkies Dec 18, 2024
850016e
Merge remote-tracking branch 'grafana/main' into karsten/reduce-alloc…
jeschkies Dec 18, 2024
42bfbbb
Revert formatting vendor
jeschkies Dec 18, 2024
5ffb733
Correct test
jeschkies Dec 18, 2024
4d00e72
Fix typo
jeschkies Dec 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add todo
  • Loading branch information
@jeschkies
jeschkies committed Dec 17, 2024
commit dc5dacd85805b43833268adf635b3f4e92528964
2 changes: 1 addition & 1 deletion pkg/logql/count_min_sketch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ func (v *HeapCountMinSketchVector) Add(metric labels.Labels, value float64) {
heap.Push(v, metric)
v.observed[metricString] = struct{}{}
} else if v.Metrics[0].String() == metricString {
// TODO: This check seems wrong.
// The smalles element has been updated to fix the heap.
heap.Fix(v, 0)
}
Expand All @@ -197,7 +198,6 @@ func (v *HeapCountMinSketchVector) Add(metric labels.Labels, value float64) {
if len(v.Metrics) > v.maxLabels {
metric := heap.Pop(v).(labels.Labels)
delete(v.observed, metric.String())
v.Metrics = v.Metrics[1:]
}
}

Expand Down
Loading