Skip to content

feat(helm): add readiness probe for memcached #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(helm): add readiness probe for memcached #15609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99b7c10
feat(helm): add readiness probe for memcached
LukoJy3D Jan 6, 2025
5b46762
feat(helm): add custom readiness probe override
LukoJy3D Jun 18, 2025
575b8a1
fix(helm): remove conditional check
LukoJy3D Jun 18, 2025
b762446
fix: back to inlined readinessprobe block
LukoJy3D Jun 30, 2025
183e934
Update production/helm/loki/templates/memcached/_memcached-statefulse…
LukoJy3D Jul 1, 2025
c58d9dd
Update production/helm/loki/values.yaml
LukoJy3D Jul 1, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6922,6 +6922,20 @@ false
<td><pre lang="json">
null
</pre>
</td>
</tr>
<tr>
<td>memcached.readinessProbe</td>
<td>object</td>
<td>Readiness probe for memcached pods (probe port defaults to container port)</td>
<td><pre lang="json">
{
"failureThreshold": 6,
"initialDelaySeconds": 5,
"periodSeconds": 5,
"timeoutSeconds": 3
}
</pre>
</td>
</tr>
<tr>
Expand Down
4 changes: 4 additions & 0 deletions production/helm/loki/templates/memcached/_memcached-statefulset.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ spec:
{{- end }}
securityContext:
{{- toYaml $.ctx.Values.memcached.containerSecurityContext | nindent 12 }}
{{- with $.ctx.Values.memcached.readinessProbe }}
readinessProbe:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if or .persistence.enabled .extraVolumeMounts }}
volumeMounts:
{{- if .persistence.enabled }}
Expand Down
8 changes: 8 additions & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3204,6 +3204,14 @@ memcached:
fsGroup: 11211
# -- The name of the PriorityClass for memcached pods
priorityClassName: null
# -- Readiness probe for memcached pods (probe port defaults to container port)
readinessProbe:
tcpSocket:
port: client
initialDelaySeconds: 5
periodSeconds: 5
timeoutSeconds: 3
failureThreshold: 6
# -- The SecurityContext for memcached containers
containerSecurityContext:
readOnlyRootFilesystem: true
Expand Down