Skip to content

fix(partition-ingester): Add stream creation error logging #15640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix(partition-ingester): Add stream creation error logging #15640

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad0924
fix(partition-ingester): Add stream creation error logging
periklis Jan 8, 2025
fd5e961
Remove obsolete lines
periklis Jan 8, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pkg/ingester/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"math"
"net/http"
"os"
"strings"
"sync"
"syscall"
"time"
Expand Down Expand Up @@ -237,6 +238,16 @@ func (i *instance) Push(ctx context.Context, req *logproto.PushRequest) error {
if err == nil {
s.chunkMtx.Lock()
}

if err != nil && strings.Contains(err.Error(), validation.StreamLimitErrorMsg) {
level.Debug(util_log.Logger).Log(
"msg", "failed to create stream, exceeded stream limit",
"org_id", i.instanceID,
"err", err,
"stream", reqStream.Labels,
)
}

return s, err
},
func(s *stream) error {
Expand Down Expand Up @@ -326,8 +337,14 @@ func (i *instance) createStream(ctx context.Context, pushReqStream logproto.Stre
}

func (i *instance) onStreamCreationError(ctx context.Context, pushReqStream logproto.Stream, err error, labels labels.Labels) (*stream, error) {
if i.configs.LogStreamCreation(i.instanceID) {
level.Debug(util_log.Logger).Log(
if i.configs.LogStreamCreation(i.instanceID) || i.cfg.KafkaIngestion.Enabled {
l := level.Debug(util_log.Logger)

if i.cfg.KafkaIngestion.Enabled {
l = level.Warn(util_log.Logger)
}

l.Log(
"msg", "failed to create stream, exceeded limit",
"org_id", i.instanceID,
"err", err,
Expand Down
Loading