Skip to content

fix: update crc64nvme to fix build issues with arm images #16413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
The arm build has been failing, which I could trace to PR adding an indirect dependency to github.com/minio/crc64nvme. However, it did not properly handle non-asm builds. There has been a new release with a fix for this build issue. This PR updates the lib from 1.0.0 to 1.0.1 to get the fix.

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner February 24, 2025 07:50
@sandeepsukhani sandeepsukhani enabled auto-merge (squash) February 24, 2025 07:52
@sandeepsukhani sandeepsukhani merged commit 80a616d into main Feb 24, 2025
62 checks passed
@sandeepsukhani sandeepsukhani deleted the update-crc64nvme branch February 24, 2025 08:01
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Feb 24, 2025

Hello @sandeepsukhani!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k243 size/XS type/bug Somehing is not working as expected
2 participants