Skip to content

fix: fix a panic in ServeHTTP where stream was nil #16818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: fix a panic in ServeHTTP where stream was nil #16818

merged 1 commit into from
Mar 18, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 18, 2025 •
edited
Loading

What this PR does / why we need it:

This pull request fixes a panic in ServeHTTP where nil was appended to a slice by mistake.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 18, 2025 16:17
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-panic-in-http-handler branch from fdeca34 to 7784f5d Compare March 18, 2025 16:18
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-panic-in-http-handler branch from 7784f5d to 8eec1a4 Compare March 18, 2025 16:28
@grobinson-grafana grobinson-grafana merged commit ba7550a into main Mar 18, 2025
61 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-panic-in-http-handler branch March 18, 2025 18:14
periklis pushed a commit that referenced this pull request Mar 20, 2025
@grobinson-grafana @periklis
fix: fix a panic in ServeHTTP where stream was nil (#16818)
92cf8ae
grobinson-grafana added a commit that referenced this pull request Mar 20, 2025
@grobinson-grafana
fix: fix a panic in ServeHTTP where stream was nil (#16818)
4c803cd
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 24, 2025
Open
This was referenced Mar 31, 2025
Merged
Open
This was referenced Apr 14, 2025
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 22, 2025
Open
This was referenced Apr 23, 2025
Merged
Merged
Merged
This was referenced May 5, 2025
Open
Open
This was referenced May 19, 2025
Open
Open
This was referenced May 26, 2025
Open
Open
This was referenced Jun 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L
2 participants
@grobinson-grafana @benclive