Skip to content

ci(helm-diff): add single binary scenario #17013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kir4h
Copy link
Contributor

@kir4h kir4h commented Apr 3, 2025

What this PR does / why we need it:

Adds the single binary scenario to Helm diff CI. It makes sense since there are templates only rendered for it.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Discussed on #16930

Edit: Added an extra commit to pass PR validations. Its content is the result of running

go mod download && go mod verify && go mod tidy && go mod vendor

As suggested by the failing test.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Signed-off-by: Andres Alvarez <1671935+kir4h@users.noreply.github.com>
@kir4h kir4h requested a review from a team as a code owner April 3, 2025 07:30
Signed-off-by: Andres Alvarez <1671935+kir4h@users.noreply.github.com>
@kir4h kir4h force-pushed the ci-helm-add-single-binary--scenario branch from 6935403 to f231729 Compare April 3, 2025 07:47
@pull-request-size pull-request-size bot added size/L and removed size/S labels Apr 3, 2025
@kir4h
Copy link
Contributor Author

kir4h commented May 6, 2025

@trevorwhitney should we add the scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant