Skip to content

feat(helm): allow custom PV/PVC configuration in StatefulSet #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kataria1shivang
Copy link

@kataria1shivang kataria1shivang commented Apr 3, 2025

What this PR does / why we need it:

This PR modifies the StatefulSet configuration in the single-binary Loki Helm chart to allow users to specify custom Persistent Volumes (PV) and Persistent Volume Claims (PVC) instead of the default automatic PV/PVC creation. This enhancement is particularly useful for environments like Amazon EKS, where custom storage classes or predefined PV/PVC configurations are required. Currently, the Helm chart automatically creates a PV/PVC, which may not meet the needs of all users, especially in environments that require custom storage configurations. This change adds the flexibility to specify user-defined PV/PVC, while maintaining the default behavior if no custom values are provided.

Notes:

  • This update modifies the StatefulSet file to allow the customization of PV/PVC.
  • It doesn’t require changes in values.yaml, but users can now specify their own PV/PVC by modifying the appropriate StatefulSet configuration.
  • The default behavior (automatic PV/PVC creation) remains intact if users don’t specify custom values.
  • This change has been verified and tested in Amazon EKS, ensuring the PV/PVC customization works as expected in cloud environments like EKS.
@kataria1shivang kataria1shivang requested a review from a team as a code owner April 3, 2025 20:50
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vijay Kataria seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants