fix: better fix integer overrun when calculating parallelism for very long time range queries - #17430
Merged
Conversation
rfratto
approved these changes
Apr 24, 2025
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#17428 didn't actually fix the issue, I had modified the test parallelism to 2048 when debugging but reverted it to the previous value in the test when cleaning up my PR.
Thanks to @rfratto for being curious here and digging a bit deeper.
The overflow was actually happening in the multiplication of the nanosecond duration of the query length and the query parallelism value.
This PR hopefully really fixes the issue by reducing the precision we use in this calculation, we don't need nanosecond precision for determining an approx weighed parallelism 👍
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR