fix(otlp): calculate entry metadata size before adding resource/scope attributes #17629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanRushing
added
opentelemetry
… attributes This change prevents negative structured metadata byte sizes by calculating the entry's own metadata size before appending resource and scope attributes, rather than attempting to subtract afterwards. This preserves the intent of tracking entry-specific metadata separately while ensuring values are always positive.
Signed-off-by: Jordan Rushing <rushing.jordan@gmail.com>
JordanRushing
force-pushed
the
negative-structured-metadata-bytes
branch
from
e744ee2 to
0f0f70b
Compare
…etadata byte tests in otlp_test.go Signed-off-by: Jordan Rushing <rushing.jordan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the issue where "negative structured metadata bytes received" errors were being logged in Loki when processing OTLP logs.
Problem
The OTLP processing code was calculating entry-specific metadata size by subtracting resource and scope attribute sizes from the total metadata size after they were already combined. This calculation could result in negative values, which were caught by guard clauses and logged as errors.
Solution
This PR changes the approach to calculate the entry's metadata size before adding resource and scope attributes. This preserves the original intent (tracking entry-specific metadata separately) while ensuring the values are always positive.
The change maintains the same accounting logic but eliminates the possibility of negative values being passed to Prometheus counters.
Testing
TestOTLPStructuredMetadataCalculationto verify structured metadata bytes are always positiveWhich issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR