feat: adds User-Agent to distributor push logging - #17764
Merged
Conversation
When capturing statistics regarding the most recent push request, extract the `User-Agent` header value from the request headers. If this value is included, strip off the trailing '/.*' content and include the agent value in the log line.
paul1r
approved these changes
May 20, 2025
aarogoss
marked this pull request as ready for review
May 20, 2025 16:37
aarogoss
enabled auto-merge (squash)
May 20, 2025 16:38
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When capturing statistics regarding the most recent push request, extract the
User-Agentheader value from the request headers. If this value is included, strip off the trailing '/.*' content and include the agent value in the log line.What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds User-Agent to the distributor logging so we can track agent types along with lag metrics.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR