Skip to content

feat: purgo package update - #17807

Merged
paul1r merged 1 commit into
grafana:mainfrom
daeho-ro:feature/purgo-update
May 23, 2025
Merged

feat: purgo package update#17807
paul1r merged 1 commit into
grafana:mainfrom
daeho-ro:feature/purgo-update

Conversation

@daeho-ro

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
purego should be update to resolve a build issue on intel macos,

  # github.com/grafana/loki/v3/cmd/logcli
  link: duplicated definition of symbol dlopen, from github.com/ebitengine/purego and github.com/ebitengine/purego

Which issue(s) this PR fixes:
There is no issue number on this repo but others

Special notes for your reviewer:
This is not a problem of loki but just affected by packages

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@daeho-ro
daeho-ro requested a review from a team as a code owner May 23, 2025 02:07
@CLAassistant

CLAassistant commented May 23, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@paul1r

paul1r commented May 23, 2025

Copy link
Copy Markdown
Collaborator

Can you run a go mod vendor on your branch? Once we have the updated vendor files we can get this merged

@daeho-ro

Copy link
Copy Markdown
Contributor Author

Here it is, @paul1r .

@paul1r paul1r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants