Skip to content

fix(stream-generator): Split create/keep-alive streams routines - #17815

Merged
periklis merged 2 commits into
mainfrom
stream-generator-split-send-loops
Jun 2, 2025
Merged

fix(stream-generator): Split create/keep-alive streams routines#17815
periklis merged 2 commits into
mainfrom
stream-generator-split-send-loops

Conversation

@periklis

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This pull request separates created/keep-alive routines in the stream generator. This enabled adding new streams at a different rate than keeping them alive.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@periklis
periklis requested a review from a team as a code owner May 23, 2025 17:07
@periklis
periklis merged commit ec5599c into main Jun 2, 2025
@periklis
periklis deleted the stream-generator-split-send-loops branch June 2, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants