Skip to content

fix(helm): move loki-sc-rules to second position in containers #17937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented Jun 2, 2025

What this PR does / why we need it:

This change prevents kubectl to default to show logs from the loki-sc-rules container by default

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
In addition to moving the loki-sc-rules I've also introduced the kubectl.kubernetes.io/default-container annotation to prevent such issues in the future.
I didn't touch the definition of either containers, I simply moved the lines around. You can verify that locally using git show --color-moved, since the GitHub UI doesn't provide such an option.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
This change prevents kubectl to default to show logs from the loki-sc-rules container by default
@tongpu tongpu requested a review from a team as a code owner June 2, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants