fix(helm): move loki-sc-rules to second position in containers #17937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change prevents kubectl to default to show logs from the loki-sc-rules container by default
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
In addition to moving the
loki-sc-rules
I've also introduced thekubectl.kubernetes.io/default-container
annotation to prevent such issues in the future.I didn't touch the definition of either containers, I simply moved the lines around. You can verify that locally using
git show --color-moved
, since the GitHub UI doesn't provide such an option.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR