refactor(stringlabels): Support stringlabels in storage. #18103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have to run the benchmarks |
|
Here are the benchmark results I've noted the once which show a slow down in the description. |
chaudum
reviewed
Jun 17, 2025
pkg/storage/stores/shipper/indexshipper/boltdb/compactor/series.go
Outdated
Show resolved
Hide resolved
Comment on lines
+38
to
+43
| ls.Range(func(l labels.Label) { | ||
| if l.Name == TenantLabel { | ||
| ls = append(ls[:i], ls[i+1:]...) | ||
| break | ||
| return | ||
| } | ||
| } | ||
| return ls | ||
| b.Add(l.Name, l.Value) | ||
| }) |
There was a problem hiding this comment.
Have you thought about encapsulating this functionality into the ScratchBuilder by adding a Remove(name string) function?
There was a problem hiding this comment.
That's a very good point!
There was a problem hiding this comment.
ScratchBuilder is owned by Promtheus. I'm trying the "normal" builder.
| @@ -45,3 +47,20 @@ func (p *PoolChunkRefs) Put(xs []ChunkRef) { | |||
| //nolint:staticcheck | |||
| p.pool.Put(xs) | |||
| } | |||
|
|
|||
| type PoolLabelsBuilder struct { | |||
There was a problem hiding this comment.
Suggested change
| type PoolLabelsBuilder struct { | |
| type LabelsBuilkderPool struct { |
There was a problem hiding this comment.
That conflicts with the variable above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a next step of support Prometheus
stringlabelsimplementation in Loki. It adds support in thestoragepackage.Special notes for your reviewer:
The tests should compile with build tag
stringlabels.Outstanding Performance Issues
Benchmark_store_SelectSamplebloom/v1BenchmarkMapClearBenchmarkNewMapBenchmarkBlockQueryingBenchmarkScalableBloomTestAndAddseries.BenchmarkParseIndexEntriesseries.index.BenchmarkEncodeBenchmark_BlocksCacheOldtsdbBenchmarkTenantHeadsBenchmarkTSDBIndex_VolumeBenchmark_MultiQueriesChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR