Skip to content

chore(bench_test): correctly integrate new query engine + misc changes #18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Jun 20, 2025

What this PR does / why we need it:

  • For StoreDataObjV2Engine we are additionally implementing Querier interface in bench test and passing that to the logql.Engine for executing queries. But the new engine can directly Exec queries and returns results in loki response format. This PR updates bench test to use the new engine directly.
  • Consistent naming for all tests query=%s/kind=%s
  • Adds new base tests for count_over_time
  • Inits stats context correctly in new engine

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner June 20, 2025 08:15
@ashwanthgoli ashwanthgoli changed the title chore(bench_test): Correctly integrate new query engine + misc changes Jun 20, 2025
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 5f3300a into main Jun 27, 2025
65 checks passed
@ashwanthgoli ashwanthgoli deleted the bench_test_cleanup branch June 27, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants