Skip to content

feat: Use the event emitter for errors in the fluentd output plugin #18252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Use the event emitter for errors in the fluentd output plugin #18252

wants to merge 3 commits into from
+164 −106

Conversation

dazoakley
Copy link

@dazoakley dazoakley commented Jun 27, 2025 •
edited
Loading

This update extends the fluentd output plugin to send logs that have failed to be sent to loki into the fluentd @error label, thus allowing users to decide what they would like to do with them.

It also updates the README and docker-compose setup so local testing is a bit more clear.

To simulate an error (so you can see it coming into the error label), issue the following curl request (using the docker-compose setup), and you should see it get output into the fluentd logs with the from_error label attached:

curl -v -X POST -H "Content-Type: application/json" -d "{ \"time\": \"$(date --date='@1700839815' '+%Y-%m-%dT%H:%M:%S.%N%:z')\", \"log\": \"This will break stuff\" }" http://localhost:8080/loki.output

Fixes #6547

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
dazoakley added 2 commits June 25, 2025 09:31
@dazoakley
Update rubygems and get the tests to pass
2e0dd57
@dazoakley
Send non-retryable errors to the fluentd @error label.
dbcb896 
This also updates the README and docker-compose setup so local testing
is a bit more clear.

To simulate an error (so you can see it coming into the @error label),
issue the following curl request (using the docker-compose setup), and
you should see it get output into the fluentd logs with the `from_error`
label attached:

```bash
curl -v -X POST -H "Content-Type: application/json" -d "{ \"time\": \"$(date --date='@1700839815' '+%Y-%m-%dT%H:%M:%S.%N%:z')\", \"log\": \"This will break stuff\" }" http://localhost:8080/loki.output
```

fixes grafana#6547
@dazoakley dazoakley requested a review from a team as a code owner June 27, 2025 11:25
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L
2 participants
@dazoakley @CLAassistant