Skip to content

fix(memberlist): allow resolution of advertise address from v6 interf… (backport release-3.4.x) #18256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Jun 27, 2025

Backport 8594d1c from #18250


What this PR does / why we need it:

#13940 introduced a change for memberlist to pick address from the interfaces defined in common instance_interface_names (previously it iterated over all available interfaces), but the method used only resolves v4 addresses.

This breaks memberlist for anyone using v6 only interfaces. This PR updates memberlist to look-up t.Cfg.Common.Ring.EnableIPv6 flag to enable the resolution of v6 addresses.

Note: Individual components are allowed to specify their own list of interfaces using <component_name>.ring.instance-interface-names but memberlist does not consider the component specific setting yet. This should be fixed in the long term.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner June 27, 2025 13:51
@loki-gh-app loki-gh-app bot added type/bug Somehing is not working as expected size/S backport labels Jun 27, 2025
@loki-gh-app loki-gh-app bot requested a review from ashwanthgoli June 27, 2025 13:51
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli enabled auto-merge (squash) June 27, 2025 13:54
@ashwanthgoli ashwanthgoli merged commit 640cd33 into release-3.4.x Jun 27, 2025
74 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-18250-to-release-3.4.x branch June 27, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
1 participant