fix(memberlist): allow resolution of advertise address from v6 interf… (backport release-3.5.x) #18257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8594d1c from #18250
What this PR does / why we need it:
#13940 introduced a change for memberlist to pick address from the interfaces defined in common
instance_interface_names
(previously it iterated over all available interfaces), but the method used only resolves v4 addresses.This breaks memberlist for anyone using v6 only interfaces. This PR updates memberlist to look-up
t.Cfg.Common.Ring.EnableIPv6
flag to enable the resolution of v6 addresses.Note: Individual components are allowed to specify their own list of interfaces using
<component_name>.ring.instance-interface-names
but memberlist does not consider the component specific setting yet. This should be fixed in the long term.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR