Skip to content

fix: pattern persistence feature flag #18285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Jun 30, 2025

What this PR does / why we need it:

There was a typo in #18214 that set the pattern writer instance as metricsWriter, causing patternWriter to always be nil, which is why we are no longer seeing patterns in ops where the are enabled.

Also, due to the bug #18214 was fixing, which resulted in pattern persistence being enabled in production prematurely, we now have customers who have persisted patterns that we don't want them to query until we fix grafana/logs-drilldown#1355 and #18213, so this PR also adds logic to only query persisted patterns when the feature flag is enabled as well.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney trevorwhitney requested a review from a team as a code owner June 30, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant