fix: pattern persistence feature flag #18285
Open
+247
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There was a typo in #18214 that set the pattern writer instance as
metricsWriter
, causingpatternWriter
to always benil
, which is why we are no longer seeing patterns in ops where the are enabled.Also, due to the bug #18214 was fixing, which resulted in pattern persistence being enabled in production prematurely, we now have customers who have persisted patterns that we don't want them to query until we fix grafana/logs-drilldown#1355 and #18213, so this PR also adds logic to only query persisted patterns when the feature flag is enabled as well.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR