Skip to content

fix: Revert "perf: Fix memory leak in cachedIterator (#17628)" (backport k264) - #18688

Merged
chaudum merged 4 commits into
k264from
backport-18687-to-k264
Aug 1, 2025
Merged

fix: Revert "perf: Fix memory leak in cachedIterator (#17628)" (backport k264)#18688
chaudum merged 4 commits into
k264from
backport-18687-to-k264

Conversation

@loki-gh-app

@loki-gh-app loki-gh-app Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Backport 0316740 from #18687


This reverts commit 87aa954.

What this PR does / why we need it:

Reverts #17628 as it seems to be affecting the correctness of forward queries. The exact problem is not well understood yet, but we suspect that we are closing wrapped iterator before consuming all of the required entires

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@loki-gh-app loki-gh-app Bot added backport size/XS type/bug Somehing is not working as expected labels Aug 1, 2025
@loki-gh-app
loki-gh-app Bot requested a review from a team as a code owner August 1, 2025 07:26
@loki-gh-app
loki-gh-app Bot requested a review from ashwanthgoli August 1, 2025 07:26

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 1, 2025
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Aug 1, 2025
…lows

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
chaudum requested a review from ashwanthgoli August 1, 2025 08:46
@chaudum
chaudum merged commit 2830e62 into k264 Aug 1, 2025
65 checks passed
@chaudum
chaudum deleted the backport-18687-to-k264 branch August 1, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/M type/bug Somehing is not working as expected

3 participants