fix(helm): Websocket related proxy_set_header to locations back to resolve high CPU usage. - #18800
Merged
Merged
Conversation
Contributor
|
Hey @jkroepke would you mind running :) |
…solve high CPU usage.
jkroepke
force-pushed
the
helm/cpu-gateway
branch
from
August 12, 2025 13:12
9c19c21 to
5840198
Compare
Contributor
Author
|
@Jayclifford345 done! + Adding a warning for end-users with customized / non-default auth settings. |
…solve high CPU usage.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reverts #18414
With #18105 we now have the ability to set proxy_set_headers on each location.
In a default configuration, I also not see any breaking change here. However, if end-users has configure additional authentications method, like mTLS, they may hay move configuration from
gateway.nginxConfig.httpSnippettogateway.nginxConfig.locationSnippetas well.Which issue(s) this PR fixes:
Fixes #18753
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR