Skip to content

feat(helm): add replicas to loki-canary deployment - #19095

Merged
JStickler merged 11 commits into
grafana:mainfrom
demon:canary-replicas
Oct 1, 2025
Merged

feat(helm): add replicas to loki-canary deployment#19095
JStickler merged 11 commits into
grafana:mainfrom
demon:canary-replicas

Conversation

@demon

@demon demon commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Currently, there's no middle ground between deploying the canary as a single replica or deploying to your entire cluster. For very large clusters, this can result in a lot of pressure on Loki. But using a single canary replica doesn't give a huge amount of confidence on the health of the deployment.

Default to 1 replica so this is a no-op change for existing setups.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Currently, there's no middle ground between deploying the canary as a single
replica or deploying to your entire cluster. For very large clusters, this
can result in a lot of pressure on Loki. But using a single canary replica
doesn't give a huge amount of confidence on the health of the deployment.

Default to 1 replica so this is a no-op change for existing setups.
@demon
demon requested a review from a team as a code owner September 2, 2025 20:16
@JStickler JStickler changed the title feat: add replicas to loki-canary deployment Sep 2, 2025
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Sep 3, 2025
Signed-off-by: Chad Horohoe <chad@horohoe.email>

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - make sense

@JStickler

Copy link
Copy Markdown
Contributor

@demon Please generate Helm Chart reference by running 'make -C docs sources/setup/install/helm/reference.md` and then checking in the update.

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ~ Set to automerge once all tests pass

The above Helm reference update still needs to be done.

@Jayclifford345
Jayclifford345 enabled auto-merge (squash) September 9, 2025 08:30
@JStickler

Copy link
Copy Markdown
Contributor

@demon still needs to generate Helm Chart reference by running 'make -C docs sources/setup/install/helm/reference.md before we can get this passing the tests.

@JStickler
JStickler disabled auto-merge September 9, 2025 16:13
@Jayclifford345

Copy link
Copy Markdown
Contributor

Hey @demon, I would love to merge this but the docs still need to be regenerated

@JStickler
JStickler merged commit c9d7d76 into grafana:main Oct 1, 2025
80 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants