Skip to content

feat: Change how analytics proxy works - #19098

Merged
DylanGuedes merged 2 commits into
mainfrom
handle-tls-with-skip
Sep 25, 2025
Merged

feat: Change how analytics proxy works#19098
DylanGuedes merged 2 commits into
mainfrom
handle-tls-with-skip

Conversation

@DylanGuedes

@DylanGuedes DylanGuedes commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Changes how we handle proxy requests for our Analytics module.
On this PR I'm:

  • Using TLS if any tls-related config is given
  • Using a different connection to the proxy vs to the analytics backend, instead of reusing the same connection.
    I had setup a proxy using https://github.com/jthomperoo/simple-proxy to test this with both, http and https.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DylanGuedes
DylanGuedes requested a review from a team as a code owner September 3, 2025 11:24
@DylanGuedes DylanGuedes changed the title Handle more TLS configs Sep 3, 2025
@DylanGuedes
DylanGuedes merged commit 82d25df into main Sep 25, 2025
68 checks passed
@DylanGuedes
DylanGuedes deleted the handle-tls-with-skip branch September 25, 2025 16:30
@loki-gh-app

loki-gh-app Bot commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Hello @salvacorts!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-3.5.x size/M type/bug Somehing is not working as expected

3 participants